Daniel Goldfarb
Daniel Goldfarb
Hi. Thank you very much for your interest in contributing code to mplfinance. The standard way to contribute code on GitHub is to use the "fork-clone workflow." I will assume...
- `git init` is ***not*** necessary since the repository already exists. (Only use `git init` when creating a brand new repository). - `fork` is a button click on github.com -...
You can tell if the `push` worked by going to [**your fork**](https://github.com/ppseverin/mplfinance) and clicking the [**compare**](https://github.com/matplotlib/mplfinance/compare/master...ppseverin:master) button. Then scroll down and look over the diff and make sure it makes...
Please see code review comments that I have posted on the PR.
Pedro, Thank you for the detailed steps. This is an interesting problem and I learned something new today, which I will share shortly. The steps are correct **except for step...
By the way, just in case you are not aware: There is a very easy way to install the version of any python package that you are working on. Simply...
Pedro, There is no rush. Take your time. Git, unfortunately, has a steep learning curve. I was using svn and resisted learning git for a long time. When I finally...
Sounds like it might be OK. You're understanding seems to be correct. I'll take a closer look soon and let you know.
> ... a merge operation should add the differences of plotting.base.py and plotting.skipped.py to plotting.py, right? This is correct! > did I have to previously delete the plotting.py file before...
> Then, I realized that probably the best way to do this is to delete the first fork and perform a new one, delete the cloned repo from my local...