Incorrect semantic token type for compile-time variable declarations

[goldenbergdaniel]

When declared with a type specifier, compile-time constants are given the semantic type of type instead of variable. The screenshots below are from VS Code using the latest version of the OLS extension.

[doongjohn]

This is happening because ols uses the type of a variable for the semantic highlighting.

SomeStruct :: struct {} // <-- correct color
struct_constant :: SomeStruct{} // <-- wrong color (highlighted as Struct Type)
array_constant :: []int{1, 2, 3} // <-- wrong color (highlighted as Array Type)
some_constant :: 10 // <-- correct color

To fix this, ols should inspect the right-hand side of constant declaration to determine whether it's a value or a type before applying semantic highlighting.

[caiolaytynher]

Do you guys believe that this could be mitigated by some change on the odin.tmLanguage.json file? I see there's a section that defines the type assignment (starting at line 139):

		"type-assignment": {
			"name": "meta.definition.variable.odin",
			"begin": "\\b([A-Za-z_]\\w*)\\s*(:\\s*:)\\s*(?=(struct|union|enum|bit_set|bit_field)\\b)",
			"beginCaptures": {
				"1": { "name": "entity.name.type.odin" },
				"2": { "name": "keyword.operator.assignment.odin" },
				"3": { "name": "storage.type.odin" }
			},
			"end": "(?=^)|(?<=\\})",
			"patterns": [ { "include": "#type-declaration" } ]
		},

I'd love to test this, but I'd need to do more research on how to build LPS for vscode first.

[doongjohn]

Constant in a different module still has incorrect color.

import "vendor:raylib"

f :: proc() {
	red := raylib.RED;
	//            ^^^ <-- It's a Constant value but colored as Type.
}

[BradLewis]

I'll think this'll mean I need to properly resolve this, I'll reopen the issue.