parameter decodeing hard codeed in openFolder function

[LudwigWen]

using:

• onedrive_tray --onedrive-path onedrive --onedrive-args "--monitor --confdir=~/.config/my-new-config" not working:

• searchIng QStringList should use regulär expressions instead and not adding +1 to notfoundValue==-1

• Missing --confdir-Parameter should use ~/.config/onedrive/config as default

• filePathes starting with ~ should be replaced by QDir::homePath()

PS: think about create new process:

• onedrive --display-config when --confdir-Parameter exists:
• onedrive --display-config --confdir=~/.config/my-new-config

[DanielBorgesOliveira]

Hi @LudwigWen ,

onedrive_tray --onedrive-path onedrive --onedrive-args "--monitor --confdir=~/.config/my-new-config" not working:

As onedrive_tray calls onedrive client, you have to indicate the full path of the onedrive client. The right way to call the program is onedrive_tray --onedrive-path [full path to your one client. E.g /usr/local/bin/onedrive.] --onedrive-args "--monitor --confdir=~/.config/my-new-config".

searchIng QStringList should use regulär expressions instead and not adding +1 to notfoundValue==-1

I did not understand what you want to say here. Can you explain me in more details?

Missing --confdir-Parameter should use ~/.config/onedrive/config as default

This parameter is part of onedrive client developed by @abraunegg. I am not sure but I think this is the default behavior of the program.

filePathes starting with ~ should be replaced by QDir::homePath()

The path we use in onedrive_tray is the path of onedrive client and this path have to be absolute as we use this path to call the program.

PS: think about create new process:

onedrive --display-config
when --confdir-Parameter exists:
onedrive --display-config --confdir=~/.config/my-new-config

Thank for the suggestion. This will be on the TODO list.

[abraunegg]

@LudwigWen , @DanielBorgesOliveira When using --confdir option, it must be used like this:

 ./onedrive --confdir '~/.config/onedrive-personal/'

or

 ./onedrive --confdir '/full/path/to/.config/onedrive-personal/'

The ~ will be expanded by the application as best as possible if it exists.

If --confdir is omitted, the application will use ~/.config/onedrive/ as a default

My suggestion here is that 'onedrive_tray' make no assumption regarding --confdir and should pass all elements of --onedrive-args to the onedrive client as-is and let the 'onedrive' client interpret the options & generate any errors if found.

[LudwigWen]

When you call search in qstringlist you are adding +1

Because your search did not find your value. Not found == - 1.

Try to change the position of parameters, you will see what is the problem.

Do you want some code suggestions?

Am 25. April 2021 22:05:47 MESZ schrieb Daniel Borges de Oliveira @.***>:

Hi @LudwigWen ,

onedrive_tray --onedrive-path onedrive --onedrive-args "--monitor --confdir=~/.config/my-new-config"

not working:

As onedrive_tray calls onedrive client, you have to indicate the full path of the onedrive client. > The right way to call the program is onedrive_tray --onedrive-path [full path to your one client. E.g /usr/local/bin/onedrive.] --onedrive-args "--monitor --confdir=~/.config/my-new-config".

searchIng QStringList should use regulär expressions instead and not adding +1 to notfoundValue==-1

I did not understand what you want to say here. Can you explain me in more details?

Missing --confdir-Parameter should use ~/.config/onedrive/config as default

This parameter is part of onedrive client developed by @abraunegg. I am not sure but I think this is the default behavior of the program.

filePathes starting with ~ should be replaced by QDir::homePath()

The path we use in onedrive_tray is the path of onedrive client and this path have to be absolute as we use this path to call the program.

PS:

think about create new process:

onedrive --display-config

when --confdir-Parameter exists:

onedrive --display-config --confdir=~/.config/my-new-config

Thank for the suggestion. This will be on the TODO list.

-- > You are receiving this because you were mentioned.

Reply to this email directly or view it on GitHub:

https://github.com/DanielBorgesOliveira/onedrive_tray/issues/13#issuecomment-826382031 -- Diese Nachricht wurde von meinem Android-Gerät mit K-9 Mail gesendet.