private-conda-repo icon indicating copy to clipboard operation
private-conda-repo copied to clipboard

Port 5060 is now in Chrome's unsafe port list

Open moqmar opened this issue 2 years ago • 2 comments

According to https://chromium.googlesource.com/chromium/src.git/+/refs/heads/master/net/base/port_util.cc#97, port 5060 can't be reached from Chromium-based browsers anymore, causing this to break with the default setup.

I'd propose to change the port to 5055, I can make a PR ready if you want?

moqmar avatar Sep 29 '22 09:09 moqmar

You can change the port exposed. For example in the snippet linked, change 5060:5060 to 8080:5060

https://github.com/DanielBok/private-conda-repo/blob/master/server/config.yaml#L35

DanielBok avatar Sep 29 '22 16:09 DanielBok

Yeah, I got it to work, but the issue is more about it not working anymore with the default configuration.

For everyone who wants a quick fix, you additionally need to re-build the "web" container with REACT_APP_API_URL set to the correct URL, you need to add that as an ARG REACT_APP_API_URL=http://xyz.local:5055 to the Dockerfile. It's used here: https://github.com/DanielBok/private-conda-repo/blob/e9c5dd8f333664abeb7fc417368ab7b3b8c6d43e/web/src/infrastructure/api/index.ts#L13-L15

moqmar avatar Oct 02 '22 09:10 moqmar