BuildSize
BuildSize copied to clipboard
Daniel15
Ensure to check all pages of comments
Currently only the first page is checked. This PR in theory should check all pages. I noticed this in this PR (https://github.com/babel/babel/pull/7646), where BuildSize was commenting over and over.
Please bear with me, because I haven't touched PHP in over a year so there might be mistakes. I was also not able to test, because I don't know how. I couldn't see tests for this and I do not know how to run it locally.
Please let me know how I can continue.
I was also not able to test, because I don't know how.
There's some docs here: https://buildsize.org/docs/development. Admittedly I haven't touched this project in a while either, but the docs should still be useful.
If you'd like, I can try this out myself, if you don't get to it.
Sent from my phone.
On Sat, Mar 16, 2019, 1:40 AM Daniel Tschinder [email protected] wrote:
Currently only the first page is checked. This PR in theory should check all pages. I noticed this in this PR (babel/babel#7646 https://github.com/babel/babel/pull/7646), where BuildSize was commenting over and over.
Please bear with me, because I haven't touched PHP in over a year so there might be mistakes. I was also not able to test, because I don't know how. I couldn't see tests for this and I do not know how to run it locally.
Please let me know how I can continue.
You can view, comment on, or merge this pull request online at:
https://github.com/Daniel15/BuildSize/pull/44 Commit Summary
- Ensure to check all pages of comments
File Changes
- M app/Listeners/GitHubCommentListener.php https://github.com/Daniel15/BuildSize/pull/44/files#diff-0 (26)
Patch Links:
- https://github.com/Daniel15/BuildSize/pull/44.patch
- https://github.com/Daniel15/BuildSize/pull/44.diff
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Daniel15/BuildSize/pull/44, or mute the thread https://github.com/notifications/unsubscribe-auth/AAFnHbCtTYXN2QuO7R9lM8CC0ntFD5siks5vXK30gaJpZM4b3sJE .
If you already have a development environment, app and repo setup, it would be nice if you could try. Otherwise I can spend some time next week to set everything up.