Daniel Leong
Daniel Leong
I reckon as a good work around, just do pure static assets as much as possible, so there is no need for the precompile. The only issue I have seen...
As suggested by @deviantony open a new ticket. https://github.com/portainer/portainer/issues/825
+1 on this as well
I guess previously, we did not have that issue. Will have a run with the verbose to see if that makes any difference or give us more to follow up...
I guess it is the test failures that is causing the problem, knapsack should have a way to handle Command failed with status (1) Might need a rescue for that...
After 20 days, I think this step is necessary to address this issue. https://github.com/ArturT/knapsack/blob/master/lib/knapsack/runners/minitest_runner.rb#L28 Add a rescue StandardError after this or maybe the following: https://github.com/seattlerb/minitest/blob/master/lib/minitest/test.rb#L19 This might be the appropriate...
@ArturT Could you try adding a failing test and see what does happen in your output? ```ruby class FailTest < ActiveSupport::TestCase def test_failure assert_equal 1, 2 end end ``` My...
Rails 5.1
I guess in design, you are trying to focus on how knapsack should behave with > The final exit code from knapsack is 1 which indicates that test suite failed...
So in that case, we should not rescue StandardError which might encapsulate too many other errors. ``` rescue SystemExit => e ``` Like the answer in the Stackoverflow post, that...