Adversarial-point-perturbations-on-3D-objects
Adversarial-point-perturbations-on-3D-objects copied to clipboard
Scripts made modular for re-usability
I have adjusted some of the scripts to make them modular, so they can be imported and used inside other scripts or executed within Jupyter notebook for further development. Take note these scripts still work well as initially planned, all I did was just to make them modular for easier reusability.
Thanks for contributing and making the code better! Here's what I think:
- Small thing: why are you removing the timestamps that prefix each file name? It is pretty convenient when running multiple experiments so the files don't overwrite each other.
- I like how you are adapting everything for Jupyter. I am interested in using Jupyter in my workflow in the future.
However, for now, I want to keep the workflow the same as before. This will be very nice for future experiments for me. I am happy that you are interested in working on a nice interface for Jupyter and using this code as a library. If you want, I can link to your fork in the README so other people have the option of using your version of the code.
Thanks for contributing and making the code better! Here's what I think:
- Small thing: why are you removing the timestamps that prefix each file name? It is pretty convenient when running multiple experiments so the files don't overwrite each other.
- I like how you are adapting everything for Jupyter. I am interested in using Jupyter in my workflow in the future.
However, for now, I want to keep the workflow the same as before. This will be very nice for future experiments for me. I am happy that you are interested in working on a nice interface for Jupyter and using this code as a library. If you want, I can link to your fork in the README so other people have the option of using your version of the code.
Well, I didn't see the need to have the timestamps in my experiment, I'd prefer that my experiments are in separate directories in the case of running multiple experiments. I felt one folder would become too cluttered overtime.
I actively use Jupyter notebooks for development and I am sure many other people out there do the same and would appreciate having a modular version of your project, that is why I thought it would be convenient to have it as such.
Yes, please feel free to update your README and link it to my fork. I am willing to collaborate wih you if you are interested.
I have linked your fork and credited you in the README. Thanks for your work. I will leave this PR open if I decide to switch to Jupyter in the future.
Great, thank you!
Hey,
If you want to create a separate PR with just the requirements.txt
, I will gladly merge it. That will make installation easier.
I just did that.