Daniel González Arribas

Results 17 comments of Daniel González Arribas

Ah, yeah, the flag name slipped. I'll change it later and apply it to other interpolant caches if everyone is happy with this.

Alright, finally got back to finishing this with remaining caches and suggestions. The docstring component is maybe a bit too wordy but everything seems to be working fine.

I've incorporated your suggestions, @sathvikbhagavan. I'm a bit unsure about the benchmark, because it's a bit expensive as a test (a few seconds) compared to most of the test suite...

> A couple of small comments. I had a quick question - should this not be used in Lagrange Interpolation or even if it is used, it wouldn't make much...

Not sure what's wrong with the format of `docs/src/manual.md`, running JuliaFormatter 1.0.59 on it does not make any changes.

I had thought that would not be an issue since the live version https://github.com/SciML/DataInterpolations.jl/blob/master/docs/src/manual.md?plain=1 seems to not have it either, let's see now

I think the main discussion regarding handling of simulteaneous events is in #519 as of now, linking it to connect the discussions (and maybe use this MWE for a test...