charts icon indicating copy to clipboard operation
charts copied to clipboard

Add liveness and readiness probes for split brain detection container

Open ninjatec opened this issue 1 month ago • 2 comments

What this PR does / why we need it:

Which issue this PR fixes

(optional, in fixes #367 format, will close that issue when PR gets merged)

  • fixes #

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • [x] DCO signed
  • [N ] Chart Version bumped
  • [x] Variables are documented in the README.md
  • [x] Title of the PR starts with chart name (e.g. [stable/mychartname])

ninjatec avatar Nov 12 '25 14:11 ninjatec

@ninjatec This would be better done as a toYaml inside the manifest, so you don't need the enable:

  splitBrainDetection:
    livenessProbe:
        ...

Then:

  livenessProbe: {{ .Values.splitBrainDetection.livenessProbe | toYaml | nindent X }}

DandyDeveloper avatar Nov 19 '25 00:11 DandyDeveloper

I have updated the code in line with your suggestion

ninjatec avatar Dec 02 '25 17:12 ninjatec

@ninjatec I fixed conflicts and removed the conditionals. They aren't needed.

If you wanted to remove the Probes entirely, you can just do:

splitBrainDetection:
  livenessProbe: ~

DandyDeveloper avatar Dec 08 '25 00:12 DandyDeveloper