charts icon indicating copy to clipboard operation
charts copied to clipboard

[stable/redis-ha]: add ability to disable default redis config

Open hawwwdi opened this issue 1 year ago • 4 comments
trafficstars

What this PR does / why we need it:

Which issue this PR fixes

When we need to disable a default Redis configuration option, such as the save option, commenting it out isn't effective because it gets overwritten by the default chart values. This PR provides a solution by allowing you to assign an empty string to that option, ensuring it is skipped when rendering Helm templates.

Checklist

  • [x] DCO signed
  • [x] Chart Version bumped
  • [x] Variables are documented in the README.md
  • [x] Title of the PR starts with chart name (e.g. [stable/mychartname])

hawwwdi avatar Aug 17 '24 19:08 hawwwdi

@DandyDeveloper Can you review this?

hawwwdi avatar Aug 21 '24 11:08 hawwwdi

@hawwwdi Is this the best solution here? I feel like this could be cryptic to people coming to the chart and implementing this themselves.

This is why the customConfig option exists.

A more sensible approach might be to store the templated string in the values directly and reference it in this helper function instead?

https://github.com/DandyDeveloper/charts/blob/abd702b5ebab0aaa6bb425bd0c3c6cbd9f404da3/charts/redis-ha/templates/_configs.tpl#L7-L40

DandyDeveloper avatar Aug 21 '24 12:08 DandyDeveloper

@hawwwdi Following up on whether you'd be able to spare some time to update this?

DandyDeveloper avatar Aug 26 '24 12:08 DandyDeveloper

@hawwwdi Following up on whether you'd be able to spare some time to update this?

Sorry for the delay. I will spend some time on this over the weekend.

hawwwdi avatar Aug 27 '24 18:08 hawwwdi

Closing as there's been no update since earlier comments.

DandyDeveloper avatar Nov 05 '24 15:11 DandyDeveloper