DandyDeveloper
[chart/redis-ha] Make exporter probes optional
What this PR does / why we need it:
This adds the option to remove the livenessProbe and readinessProbe from the exporter container.
Which issue this PR fixes
Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
- [x] DCO signed
- [x] Chart Version bumped
- [x] Variables are documented in the README.md
- [x] Title of the PR starts with chart name (e.g.
[stable/mychartname])
@sonrai-doyle May be better here to do a toYaml templating for the probes that way if people want to remove it they just add the following to the values file:
livenessProbe: {}
@sonrai-doyle Any way you can update / give input on my comment? Will close soon if I don't hear from you.,
Sorry @DandyDeveloper missed your comment while I was away on vacation. Will look at making the suggested change as I can.
+1 Waiting for this, sometimes Redis wants to recover, and we want exporter to be enabled (without probes) since it will get timeouts, etc. and makes entire pod to be unavailable.
@DandyDeveloper Sorry for the delay in addressing your comments. Would you be able to re-review?
@sonrai-doyle But that would be better if we can make all of the probes optional (some times we want to disable probes for all of the containers for debugging, etc.)