charts icon indicating copy to clipboard operation
charts copied to clipboard

[chart/redis-ha][REQUEST] use fullname template in test container name

Open elchenberg opened this issue 3 years ago • 1 comments

This is a non-issue but if you are open to it I would be happy to open a pull request. :slightly_smiling_face:

Is your feature request related to a problem? Please describe.

The name of the test container uses .Release.Name and not template "redis-ha.fullname". When I install the redis-ha chart as a dependency of a different chart, for example "trivy", the name of the container changes from "redis-ha-service-test" to "trivy-service-test" (wich might be confusing).

Describe the solution you'd like

template "redis-ha.fullname" is used for the container name.

Describe alternatives you've considered

  • not changing the container name because it does not really matter
  • use a hardcoded name like redis-ha-service-test or redis-service-test

Additional context Add any other context or screenshots about the feature request here.

elchenberg avatar Sep 02 '22 07:09 elchenberg

@elchenberg On it, might take a couple of days as I have limited PC time. Very quick change and makes sense.

DandyDeveloper avatar Sep 18 '22 08:09 DandyDeveloper