charts icon indicating copy to clipboard operation
charts copied to clipboard

[charts/redis-ha] fix: redis and haproxy and busybox image was migrated from docker hub to public ecr for docker hub rate limit

Open kahirokunn opened this issue 3 years ago • 6 comments

What this PR does / why we need it:

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

  • fixes #

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • [x] DCO signed
  • [x] Chart Version bumped
  • [x] Variables are documented in the README.md
  • [x] Title of the PR starts with chart name (e.g. [stable/mychartname])

kahirokunn avatar Jul 29 '22 01:07 kahirokunn

@kahirokunn I'm not seeing any mentions of this being an official migration?

https://hub.docker.com/_/redis

Can you throw me something confirming this as an official migration?

DandyDeveloper avatar Aug 17 '22 00:08 DandyDeveloper

@DandyDeveloper https://aws.amazon.com/jp/blogs/news/docker-official-images-now-available-on-amazon-elastic-container-registry-public/

Is this information sufficient?

kahirokunn avatar Aug 17 '22 02:08 kahirokunn

What about Google's cache proxy for DockerHub? But this is a bit specific to users for example I'm using my own docker registry docker.karimi.dev :) or some users bought docker hub account

mhkarimi1383 avatar Aug 22 '22 17:08 mhkarimi1383

@kahirokunn I'm gonna see if I can dig and find an official word that its right to use this. Sorry for the delay.

DandyDeveloper avatar Aug 23 '22 00:08 DandyDeveloper

@DandyDeveloper I did find an official announcement from docker.

I think it's best to leave it to the default of docker.io/library to avoid confusion. Personally it makes no difference to me, but I do not believe public.ecr.aws/docker/library/ is widely known or adopted in the community yet.

34fathombelow avatar Aug 26 '22 07:08 34fathombelow

If you are considering a rate limit, I would suggest using a registry that is mirrored by docker.io. AWS, GCP, GitHub, whatever, but a trusted and proven organization is preferred.

In fact I got stuck with docker.io's rate limit and failed in production.

kahirokunn avatar Aug 26 '22 07:08 kahirokunn