charts icon indicating copy to clipboard operation
charts copied to clipboard

[charts/redis-ha] Add labels to volume claim template

Open sl4dy opened this issue 2 years ago • 1 comments

Signed-off-by: Milan Sladky [email protected]

What this PR does / why we need it:

Allow addition of labels to volume claim template in the StatefulSet.

Which issue this PR fixes

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • [X] DCO signed
  • [X] Chart Version bumped
  • [X] Variables are documented in the README.md
  • [X] Title of the PR starts with chart name (e.g. [stable/mychartname])

sl4dy avatar Jul 21 '22 14:07 sl4dy

@DandyDeveloper this will also be very helpful! Please, review! Thanks!

lord-kyron avatar Jul 22 '22 10:07 lord-kyron

@DandyDeveloper please, check this - it seems helpful also.

lord-kyron avatar Aug 12 '22 06:08 lord-kyron

FYI:

Error: INSTALLATION FAILED: StatefulSet in version "v1" cannot be handled as a StatefulSet: json: cannot unmarshal number into Go struct field ObjectMeta.spec.volumeClaimTemplates.metadata.labels of type string

This was broken. I have fixed it with a new commit.

DandyDeveloper avatar Aug 17 '22 00:08 DandyDeveloper