charts icon indicating copy to clipboard operation
charts copied to clipboard

[stable/redis-ha] feature: adding option to use existing persistent volume

Open bih-goncalves opened this issue 3 years ago • 3 comments
trafficstars

What this PR does / why we need it:

Enables a user to mount a pre-existing persistent volume claim as volume to redis-ha pods to store all redis cluster data. This allows users to store the redis cluster data on any storage backend that they desire to use. We are using a pre-existing Gluster storage class.

Special notes for your reviewer:

Checklist

  • [ ] DCO signed
  • [X] Chart Version bumped
  • [X] Variables are documented in the README.md
  • [X] Title of the PR starts with chart name (e.g. [stable/mychartname])

co-author: @robbie558

bih-goncalves avatar May 18 '22 13:05 bih-goncalves

@bih-goncalves I wonder if this is the best implementation? This assumes the PVC in question is a RWX supported volume.

I'll have a think before merging this and offer some suggestions.

DandyDeveloper avatar May 25 '22 00:05 DandyDeveloper

Thanks for considering @DandyDeveloper. Given that the PVC could be written to by multiple pods, would it not need to be RWX?

Robbie558 avatar Jun 15 '22 13:06 Robbie558

@Robbie558 I think this is my concern here. Why do we have 3 instances writing to a single PVC? Are they not all writing to the same db file / fs?

Does this ruin the point of HA as corruption will potentially damage the cluster irreversibly?

DandyDeveloper avatar Jun 28 '22 01:06 DandyDeveloper

Closing as I haven't heard back from the original contributor.

DandyDeveloper avatar Aug 26 '22 01:08 DandyDeveloper