Checklist for Nordic Filters unbreakage tempfixes

[DandelionSprout]

As a logical outcome of THEtomaso often @-ing me to add quick or long-lasting tempfixes for Nordic sites reported to other lists, I realised I needed a checklist to know which quickfixes to add and/or remove from Nordic Filters.

Still open

• https://github.com/ryanbr/fanboy-adblock/issues/1243
• https://github.com/ryanbr/fanboy-adblock/issues/1339
• https://github.com/ryanbr/fanboy-adblock/issues/1468

Closed in a perceived-to-be-incomplete state

• https://github.com/ryanbr/fanboy-adblock/issues/1261
• https://github.com/easylist/easylist/issues/12067 (for non-uBO users)

[THEtomaso]

@DandelionSprout:

Regarding the Blaklader sites..

The sites are also broken by various other filters, including EasyList Cookie List, EasyPrivacy and Fanboy's Annoyance List: https://github.com/easylist/easylist/issues/10565/

..so, in addition to the fixes that you've already added, these are needed too:

blaklader.*#@#.optanon-show-settings
blaklader.*#@##onetrust-banner-sdk
blaklader.*#@##to-the-top

PS: I really don't expect anything more that a semi-working fix from ryanbr, at best. And when that time comes, I'm not sure if I'll bother to re-open my report (like usual), because I'm quite frankly getting tired of it!

--

EDIT: I was wrong. ryanbr has adopted all the necessary fixes for his filters now. :+1: Fixes for AdGuard's filters are still pending though.

[THEtomaso]

@DandelionSprout: OK, the Blaklader.* issues have been fixed in all of the most relevant filters now, so the temp-fix can safely be removed! :)

[THEtomaso]

Add these:

skousen.no,skousen.dk#@#body,html:style(height: auto !important; overflow: auto !important)
skousen.no,skousen.dk#@##cookie-information-template-wrapper

Info: https://github.com/easylist/easylist/issues/10757#issuecomment-1053603292

[ryanbr]

Why not fix it in Adguard rather than a fix it a regional list, if that's the issue

[DandelionSprout]

I've just rose up from bed this morning, and am therefore not certain about what AdGuard Annoyances Filter has to do with any of this.

[THEtomaso]

@DandelionSprout:

These open issues also affects Nordic domains: https://github.com/ryanbr/fanboy-adblock/issues/1339/ ~~https://github.com/ryanbr/fanboy-adblock/issues/1372/~~ https://github.com/ryanbr/fanboy-adblock/issues/1376/ ~~https://github.com/ryanbr/fanboy-adblock/issues/1405/~~ https://github.com/ryanbr/fanboy-adblock/issues/1410/ https://github.com/ryanbr/fanboy-adblock/issues/1468/

Perhaps some of those things have changed server-side by now, thereby eliminating the need for a fix. I'll look into it later.

[THEtomaso]

@DandelionSprout:

OK, I went through the reports that I linked to in my previous post, made some changes where necessary, and closed a couple of them due to site changes. You should look into the remaining ones.

[DandelionSprout]

Okay, so from what I pieced together from multiple conversations spread around, is that in regards to Skousen, Fanboy seems to believe (I could be wrong on this) that there's a conflict between EasyList Cookie List and AdGuard Annoyances Filter, with the latter blocking cookieinformation.com and the former doesn't.

I'll look into the 4 reports in https://github.com/DandelionSprout/adfilt/issues/462#issuecomment-1054254575 at some point (I'm pretty booked up this evening).

[THEtomaso]

Judging from his post here, he seems to believe that the sites work, simply because they're browsable: https://github.com/easylist/easylist/issues/11064#issuecomment-1054126209

Guess he overlooked the reproduction steps, in my first post here: https://github.com/easylist/easylist/issues/10757/

[THEtomaso]

I'll look into the 4 reports in https://github.com/DandelionSprout/adfilt/issues/462#issuecomment-1054254575 at some point

Regarding #1410: Under "Other problem filters", I've listed a nasty rule for ekstrabladet.dk, found in Schacks Adblock Plus liste. You should probably override that rule in your filter too, just in case some poor saps (like myself) are crazy enough to still be using that outdated filter! :)

[THEtomaso]

https://github.com/DandelionSprout/adfilt/commit/6623e62931ab68e683d76f6aa1080a04ccd86457

ekstrabladet.dk#@#body > div[id][style] won't work, because Schack didn't formulate it that way. It has to be ekstrabladet.dk#@#body>div[id][style] !

[THEtomaso]

Fixed: https://github.com/easylist/easylist/commit/4926fbebd34b6f546dd5bfc6abe6bcd1ee688b50

For some reason, he decided not to remove the :style rule. It doesn't break anything though.

[THEtomaso]

@DandelionSprout: hvemder.no: https://github.com/easylist/easylist/issues/11357/

--

EDIT: Fixed in https://github.com/easylist/easylist/commit/564fb7ce32819329f311f7a402d276b627407c27

[THEtomaso]

@DandelionSprout: e24.no: https://github.com/easylist/easylist/issues/11455/

--

EDIT: Fixed in https://github.com/easylist/easylist/commit/ffab617c90a843462cc9b9d1816875c134fe5c5b

[THEtomaso]

bookworld.no: https://github.com/easylist/easylist/issues/11668/

--

EDIT: Fixed in https://github.com/easylist/easylist/commit/a5ea95b4438f29f12bab5636ad68cf4c2885d0f8

[THEtomaso]

Elektroskandia.no fixed in https://github.com/easylist/easylist/pull/8431/commits/05d5f7e5e12c2fb4044efcbe471df0484b5f0f2d + https://github.com/easylist/easylist/commit/584a61933c1aa737b3226a41568a878423173ce2

[THEtomaso]

https://github.com/easylist/easylist/issues/7805/ fixed in https://github.com/easylist/easylist/commit/544e0548c526ebb4a84419466901e03856cf0d1e

[THEtomaso]

clasohlson.com: https://github.com/easylist/easylist/issues/12067/

[THEtomaso]

https://github.com/easylist/easylist/issues/12067/ fixed in https://github.com/easylist/easylist/commit/cc74ddc4b38ff44e8e324399caffda7bf3071aba

[DandelionSprout]

Krystian pointed out to me at https://github.com/DandelionSprout/adfilt/commit/6340cf0d9857f22093a46089022d030b771592d6#commitcomment-74157847 that https://github.com/easylist/easylist/commit/cc74ddc4b38ff44e8e324399caffda7bf3071aba only seems to cover the uBO extension file, unless I've missed out on something.

[THEtomaso]

This seems to have been the case for a while now, with Easylist Cookie List. Many of the fixes that ryanbr has added to it has been for uBO only, despite the fact that I've suggested simple ABP-compatible alternatives. I really don't understand his policy in this regard, so I'm waiting for him to clarify it here: https://github.com/easylist/easylist/issues/12011#issuecomment-1126547259

--

EDIT: ...aaand the issue was closed, without answering my question! :(

[DandelionSprout]

Closing this thread in favour of #779 and/or a hypothetical future spinoff discussion of that discussion.