Daniël Heres
Daniël Heres
Running /benchmark once more to see if previous run was noise
Yeah seems noise, different queries running slower in second run.
I don't think this issue should be closed. #9676 seems to take care of ordering but I think it doesn't improve range/inequality joins much?
Nice @junjunjd . I think the remaining work is to add it as well to projection push down :)
@junjunjd FYI, I merged and pushed some changes towards pushing projection pushdown.
@junjunjd FYI, I've committed a working version. The remaining work is fixing test (expectations) and/or remaining issues.
Current version (not sure where the regressions come from, but results are promising): @junjunjd ``` -------------------- Benchmark tpch_mem.json -------------------- ┏━━━━━━━━━━━━━━┳━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┓ ┃ Query ┃ main ┃ projection_filter_exec ┃ Change ┃ ┡━━━━━━━━━━━━━━╇━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━┩...
@junjunjd if you are able to work on this, it would be good to fix the remaining tests (either test need to be changed or expected output needs to be...
Ok, on a flight I got some more time to find the regression. It was related to join selection and statistics. Current version shows no regressions anymore 🎉 ``` --------------------...
As adding it to the logicalplan seems to cause a lot of trouble, I plan on moving this to the physical plan optimization phase only.