time_machine icon indicating copy to clipboard operation
time_machine copied to clipboard

Any plans to migrate this package to dart sound null safety

Open venkata-reddy-dev opened this issue 3 years ago • 9 comments

Hello @Dana-Ferguson , this is a great package

Any plans to migrate this package to dart sound null safety

venkata-reddy-dev avatar Mar 05 '21 03:03 venkata-reddy-dev

I did a rough draft of null safety in this PR

https://github.com/Dana-Ferguson/time_machine/pull/50

It probably doesn’t fully work yet. I did it more as an exploration in what would be necessary for supporting null safety in this quite complex package.

I’d be happy to work on this further, but I’d like to have some conversation with the package maintainers first, to make sure I’m on the right track with the changes I’ve made.

SteveAlexander avatar Mar 06 '21 08:03 SteveAlexander

Really need this for the openapi-generator.

kuhnroyal avatar Mar 28 '21 11:03 kuhnroyal

I've been polishing up the null-safety PR. As of now, there are no analyzer errors on the branch (pedantic analysis rules), 10000 tests pass and zero tests fail ~~one test fails. I'm looking into the failing test now.~~

So, this is ~~almost~~ ready for review.

SteveAlexander avatar Mar 28 '21 11:03 SteveAlexander

@SteveAlexander I wanted to say thank you for your work. This is one of the very few dependencies that hold my projects to move forward with null safety.

benjdero avatar Apr 04 '21 18:04 benjdero

Thanks @benjdero. I know there's a number of people keen to see a null-safe release.

I've been talking with @Dana-Ferguson, author of this package, who is reviewing the null-safety PR. I'm hopeful we'll be moving this forward, and doing a new time_machine release in the near future.

SteveAlexander avatar Apr 04 '21 19:04 SteveAlexander

@SteveAlexander Sure. No pressure. I just wanted to say thank you.

benjdero avatar Apr 04 '21 19:04 benjdero

Noticed the PR was merged, can we get a new release on pub.dev too? @Dana-Ferguson

brouwer avatar Apr 12 '21 07:04 brouwer

@kuhnroyal, is this issue still what you are waiting for in order to make operapi-generator generate null-safe code? @Dana-Ferguson, when can we expect this issue to be solved?

markbeij avatar May 12 '21 08:05 markbeij

Yea, the time_machine option in the dart-dio generator is still waiting on this to be migrated.

kuhnroyal avatar May 12 '21 10:05 kuhnroyal