dwsim icon indicating copy to clipboard operation
dwsim copied to clipboard

[Bug] Wrong diameter in pipe unit operation code?

Open HaSchneider opened this issue 1 year ago • 3 comments

In the pipe unit operation the outer diameter seems to be calculated by:

(Dext + esp_isol)

Shouldnt it be:

(Dext + 2* esp_isol)

Because esp_isol is the thickness of the isolation and Dext the external diameter of the pipe.

HaSchneider avatar Oct 16 '24 08:10 HaSchneider

you're right! thank you for reporting

DanWBR avatar Oct 16 '24 13:10 DanWBR

There are actually some more lines in the file where the incorrect diameter expression is used. For example 1488, 1520, 1526, 1529, 1542, ...

HaSchneider avatar Oct 17 '24 12:10 HaSchneider

@HaSchneider ok, I'll check the entire code after finishing some stuff here

DanWBR avatar Oct 17 '24 13:10 DanWBR

https://github.com/DanWBR/dwsim/commit/a018cdc9b74e7275deb913166b772cdd5665550d

DanWBR avatar Oct 29 '24 11:10 DanWBR