Dan Van Atta

Results 79 comments of Dan Van Atta

The way items in a production panel are displayed was updated recently to avoid horizontal scrolling. IIRC @asvitkine could you advise on this issue?

Looking at the list of releases, it looks like they sort chronologically and not by name: https://github.com/triplea-game/triplea/releases ![Screenshot from 2022-06-26 19-45-14](https://user-images.githubusercontent.com/12397753/175850428-0a40cba6-a491-4227-a255-b3d4ce1491f0.png) Do you see different @asvitkine ? > 2. They...

We'll be in for trouble come July. It's possible to head directly to those expected releases, they are there, and are pretty recent. It's hard to tell what the sorting...

https://github.com/triplea-game/triplea/pull/10796 will update the version numbers to replace run number with Git SHA. That would avoid the impending numbering collision.

I like this, but the date in version number creates a problem which is non-trivial to solve: ``` 2.7.0827+SHA 2.6.0703+SHA 2.6.0627+SHA [major].[release].[MMDD]+[Git SHA] ``` The above gives the date in...

### Bumping version number to solve ordering @asvitkine simply bumping version unfortunately does not solve the new problem we have "(1) - Need build number in two places at different...

@asvitkine let me try to state the new constraints more precisely: - we need a stable version number that is deterministic. This allows to build assets with a given version...

@asvitkine re- ordering. Same day results right now might be out of order. Github releases is very opinionated to assume releases will be a semver. Only if the semver matches...

@TheDog-GH The example of bisecting by version number is an interesting consideration. When bisecting myself, I use a list of git commit SHA's and then bisect that list. As a...

Unfortunately the CI does a sparse checkout and reads the number of commits as '1'. I'm working on removing version number from build artifacts. Recall, that so long as we...