Danny Tuppeny

custom_lint fails to run "pub get" on Windows with spaces in paths

3

When trying to repro an issue for @pattobrien, I noticed custom_lint was failing to start: ``` The request analysis.setContextRoots failed with the following error: RequestErrorCode.PLUGIN_ERROR Exception: Failed to run "pub...

[test_reflective_loader] Use test groups instead of combining names

33

@scheglov this change switches to using `package:test` groups instead of just combining names (https://github.com/dart-lang/tools/issues/2104). This would improve how things appear in the VS Code test runner because there would be...

Improve error message when failing to add a breakpoint to a script that isn't loaded

1

Moving this from https://github.com/Dart-Code/Dart-Code/issues/5632 (filed by @oliver-whale). If you add a breakpoint to a file that is not called, the error that comes back looks like this: I wonder if...

[server_plugins] Race during plugin startup/restart can result in "Null check operator used on a null value" when applying document changes

2

This was raised at https://github.com/Dart-Code/Dart-Code/issues/5817 by @FMorschel and I was able to reproduce it by adding an artificial delay during plugin startup. The error occurs when the plugin is trying...

Function tearoffs are not represented as FunctionReference in resolved AST

4

The dartdoc on `FunctionReference` has this example: ``` /// An expression representing a reference to a function, possibly with type /// arguments applied to it, e.g. the expression `print` in...

Can't record past event using the dart:developer Timeline and TimelineTask APIs

21

I thought it would be useful to be able to use the DevTools performance page for debugging performance issues with the analysis server. The server already has some classes that...

I've seen this test failing on PRs lately: ``` Unhandled exception: Exception: Test 'memory eval and browse' failed: ══╡ EXCEPTION CAUGHT BY FLUTTER TEST FRAMEWORK ╞═════════════════ The following assertion was...

In https://github.com/Dart-Code/Dart-Code/actions/runs/19813360325/job/56776641967 there are some errors like this - likely due to the races restarting the LSP server: - https://github.com/microsoft/vscode-languageserver-node/issues/725 - https://github.com/microsoft/vscode-languageserver-node/issues/1559 ``` [10:16:19 AM] [General] [Warn] Failed to update...

"Add Dependency" quick-fixes for pubspec.yaml files should be moved from Dart-Code to the server

6

See https://github.com/dart-lang/sdk/issues/55985 We currently inject this fix locally. We need to move it to the server, and ensure we move over in a way that nobody sees duplicate (or missing)...

Default to running tests by line when they might otherwise fail

1

We have a setting to run tests by line (instead of by name), but it's opt-in. We could solve some issues by automatically defaulting to using lines if we think...