github-codespaces-flutter-web icon indicating copy to clipboard operation
github-codespaces-flutter-web copied to clipboard

Not working

Open hairy-tortoise opened this issue 1 year ago • 4 comments

When I start a codespace, launch the app and go to the exposed port I get the Flutter loading, but it never finishes. I don't get any errors in the console.

hairy-tortoise avatar Apr 13 '24 00:04 hairy-tortoise

Yeah, this doesn't seem to work for me anymore. When I click the Dart Debug Extension button I start getting this notification appearing:

Screenshot 2024-04-18 104908

And it just keeps appearing every few seconds, even after I've closed the app window.

I have all ports set to public:

Screenshot 2024-04-18 104914

@elliette do you know what this error is? It's not very clear from the notification I see, and I can't find any more details in any of the consoles for the app or by trying to inspect the extension (there used to be a way to view the "background page" I think, but now I only see a service worker link, and the console there is clear).

(this isn't a priority, but it'd be good to understand what's broken.. it's very possible it's something on codespaces, but the error isn't helpful)

DanTup avatar Apr 18 '24 09:04 DanTup

Ah yes, this was added to fix a potential security vulnerability in the extension (details here: https://github.com/dart-lang/webdev/issues/2287)

elliette avatar Apr 18 '24 16:04 elliette

@elliette oh, I see - so do all domains need whitelisting now? Is it possible for the user to add their own (or could we prompt to ask them, rather than just blocking)? (again, not a priority - but would be a shame to lose the ability to use this on services like Codespaces).

DanTup avatar Apr 18 '24 16:04 DanTup

There's an open issue at https://github.com/dart-lang/webdev/issues/2375 tracking support for custom domains that aren't localhost.

DanTup avatar Apr 18 '24 18:04 DanTup