Danny Tuppeny
Danny Tuppeny
I don't know if I agree with what I wrote above now.. For classes, showing all of the agumentation classes makes sense to me, but if we're talking about invocations...
> I'd probably remove the "but" and just say that Declaration should go to the same place as Definition when there's only one reasonable place to go. Unless that's counter...
You're right, it is less clear than I thought :) We can indeed return multiple results for Go-to-Declaration too, but you're right that it doesn't help answer all of the...
I had a little dig into the VS Code APIs for "Peek Location" to see how they'd work triggered from CodeLens. Unfortunately this isn't standard LSP so would require some...
> That's also unfortunate. It wouldn't be so bad if we could disable the menu item when it doesn't apply, but I'm guessing that we can't. This is unfortunately correct....
I hacked up an example of using CodeLens for various kinds of navigation like this (Super, Overrides, Augmented, Augmentation):  I realised that Super/Overrides and Augmented/Augmentations are not quite as...
> Should "Go to Super" go to the same place as navigating from the keyword `super`? Would it be too confusing if they didn't, or would it just make it...
How does the following sound: 1. We ensure the "Go to Super" command goes to the place that a `super()` call would invoke - Probably this is currently not going...
The changes above support "Go to Augment(ed|ation)" CodeLens. We don't yet have CodeLenses for other things (like Go to Super), and I don't know if we want to do that...
It won't be possible to implement this in a seamless way as described above. VS Code controls the editor and just sends us (asynchronous) events as modifications are made *....