Danny Tuppeny

Results 1795 comments of Danny Tuppeny

> No, it's really inside the VS Code window. Or can it be an iframe? It is an iframe inside VS Code that is rendering DevTools when embedded. Does the...

I've pushed some additional minor changes, and done some more manual tested in DevTools and comparisons to the NPM tool. With a little cleanup (because the NPM tool doesn't always...

Ug, apparently restarting a job on Travis reuses the same link, so the link above no longer goes to the failure log (well, unless it fails again!).

Marking them as allowed failures might be good - we get to see how often they're working (and get the errors to investigate) without them blocking. Can you post links...

Found another cause of some of our Windows test failures: https://github.com/flutter/devtools/blob/master/tool/travis.sh#L137 This line is running tests without `-j1`, but some of these tests are running Flutter and trying to write...

The delay I added in #218 was removed (we now have an `app.devToolsReady` event), though I don't think I've removed any others (I think we still have a lot). I'm...

FWIW, I reduced the delays from 100 and 500ms to 1ms and 5ms on a branch, and only 2 tests per-bot failed: https://travis-ci.org/DanTup/devtools/builds/562960623 It's possible it's made others more flaky,...

> @DanTup do you have time to take a look at the integration tests and fixing the build from server? You probably have the most knowledge of this code. I'm...

> and fixing the build from server? Missed this - but not sure exactly what this refers to?

@kenzieschmoll is the problem that it launches with to a white empty page? If so, that will be fixed by https://github.com/flutter/devtools/pull/1975 - the script was still building both versions and...