Danny Tuppeny

Results 1795 comments of Danny Tuppeny

Unfortunately not.. VS Code just asks us for the range of the definition and then it goes and reads the file contents for that range and shows it here. If...

This is fixed by https://github.com/dart-lang/sdk/commit/0b170c759eae6c736f5ce390286eed0df31eb334. The change is in the Dart analysis server so will show up in a future Dart/Flutter SDK release (rather than a Dart-Code extension release).

We currently set some env variables that other tools use for this: https://github.com/Dart-Code/Dart-Code/blob/37ae5ace42c372c1c65ae7797d892cac21128ee2/src/extension/utils/processes.ts#L27-L28 Env variables have a slight benefit in that they're inherited by child processes automatically (so if DevTools...

@dcharkes I think this is handled by inlay hints (see https://github.com/dart-lang/language/issues/3502#issuecomment-1847310443 / https://github.com/Dart-Code/Dart-Code/issues/3609 ?

We could, but I'm not sure if it would be obvious to users what's happening there. Since we don't display these by default, we've so far always been very explicit...

My concern here is that it might not always be obvious to a user why a hint is missing and that could be confusing. For example a static method might...

> I guess I'm going to have to upvote my own issue? 😆 heh, I often upvote my own in the VS Code tracker - it makes it less clicks...

> "Find all references" at any of (1), (2), or (3) should find all three. I'm not convinced that's the right behaviour. Find references should find references to the selected...

> I think I'm convinced by this discussion that find references should behave the same as mark occurrences and rename. I've implemented what I think we're agreeing here at https://dart-review.googlesource.com/c/sdk/+/364120....

I would not expect my change above to affect this - it only changes Find References. If you can reproduce this, please do file an issue (at https://github.com/dart-lang/sdk). Will keep...