Danny Tuppeny

The server has support for renaming folders since https://github.com/dart-lang/sdk/commit/729b2e5d34bbca2a899ba12c7738cfa0bc3fa3b6, but it will require changes in IntelliJ/Android Studio to call the API for folders. For VS Code, I'm waiting on a...

I don't seem to be able to repro this with VS Code, although it's a little similar to https://github.com/Dart-Code/Dart-Code/issues/3498 where additional builds were happening that was caused by VS Code...

If you enable something like painting overlays I assume it needs to rebuild. I figured maybe it was always triggering the rebuild even if the value didn't really change (which...

> @DanTup is this something that could be added to VS Code? I saw that LSP had the basic protocol, but I doubt the analyzer handles @marco there, either. The...

In VS Code, we handle the normal Restart button/menu entries as a Hot Restart, so as long as the user is clicking Restart, it'll be a Hot Restart. It could...

This was fixed in the last update via #4089.

@bwilkerson this issue occurs because when we resolve a completion (to add documentation) we do so based on the completion text (and look for a top-level element with that name)....

> My only potential concern is performance. Your idea of making the location conditional based on the protocol being used protects legacy protocol clients, so there's no danger there. For...

SGTM - I haven't gotten to looking at this properly yet (and probably won't until next week now), so if there are other ideas/feedback before then let me know (or...

@bwilkerson I [started taking a look](https://github.com/DanTup/sdk/commit/e57218b7c2e84d532e8c4762f310d16f3ec82b11) at adding a non-protocol `CompletionSuggestion` class, although there are some things that make it awkward that I hadn't thought about: - `protocol.CompletionSuggestionKind` is used...