Danny Tuppeny
Danny Tuppeny
oops, forgot /verified
@daytonellwanger is there a way to log traffic between the client/host? @lukepighetti some things to check: - Does it happen if you disable autoImportCompletions? With this enabled, the completion results...
Payloads with `autoImportCompletions` turned off shouldn't be massive - but it will depend a lot on how many libraries you've imported and symbols are in scope. They will typically be...
I tried exporting the Live Share logs, but it didn't seem to include the payloads going over the wire. Adding logging to the completion item provider shows that there are...
@daytonellwanger so do you call that method, then just `JSON.stringify` the results and send them to the client? If so, I'll test that to see whether the internal data is...
I called `vscode.commands.executeCommand('vscode.executeCompletionItemProvider')` and serialised the results, and it did *not* include all of the internal data mentioned above (which is what I expected/hoped). This means the actual payload is...
> the `executeCompletionItemProvider` command takes an optional argument for specifying the number of completion items to resolve Yeah, I use this in tests and have issues with its design (you...
> Doesn't LSP support streaming of completion items as of 3.15? See here. Not sure if VS Code yet supports it, but I would assume it does.. My understanding is...
@daytonellwanger ah thanks, I was unaware of that. Unfortunately you're right, and VS Code doesn't support this (https://github.com/microsoft/vscode-languageserver-node/issues/528). > With completion, it might not make as much sense... I'm not...
It would actually work out better if we could also attach additional data into the clipboard during copy (to avoid there being a mismatch between the import data we stashed...