Danny Tuppeny

Results 1795 comments of Danny Tuppeny

This is unfortunately [a known limitation](https://dartcode.org/releases/v3-1/#preview-flutter-ui-guides) because VS Code doesn't give us a clean way to draw arbitrary lines (so we have to use ascii characters which are the same...

@robertpiosik the lines are rendered from Ascii characters, to changing the size will push the lines further out when there are multiple in the same line (I'm also not certain...

Oops, I thought this issue was #3585 so my response was thinking about scaling in X (making the lines wider). Although, generally the response is the same. I don't think...

@robertpiosik how are you adding that transform to the extension code? We have limited CSS capabilities, we can't just add arbitrary CSS: https://github.com/Dart-Code/Dart-Code/blob/d7555d8ea56162f160ad49db77bd09d5c24140f4/src/extension/decorations/flutter_ui_guides_decorations.ts#L113

Ah - I thought you'd found something I'd missed. Yeah, it kinda sucks. Please do add 👍 's to https://github.com/microsoft/vscode/issues/73780 if you haven't already. A good API from VS Code...

@bkonyi do you know if this is expected to work? I was certain it did (except for Flutter), but I can repro this and it doesn't work. When you Go-to-Definition...

> `dart:` URIs should be converted before calling VM Service `addBreakpointWithScriptUri` RPC I'm not certain this is the correct place to fix this versus the VM. When we step into...

@bkonyi > Yeah, this should almost certainly be fixed in the VM. Ok, I will file some bugs in the SDK later with clear examples of the issue and how...

Thanks for the digging! My only concern with shipping this workaround here, is that if it's fixed in the VM in a way that stops `/dart:core` from working, things wouldn't...

@bleroux is this now resolved by https://github.com/dart-lang/sdk/issues/47204 or are there still issues?