Danny Tuppeny

Results 1795 comments of Danny Tuppeny

> "https://localhost:5173/f/" is not a valid HTTP URL. I misread your original issue thinking the trailing slash was the issue, but now I see it's HTTPS. I believe this is...

@bkonyi @a-siva I'm trying to figure out whether this has always been the behaviour and whether it's expected or not. Relevant parts of the log are below. We call `setLibraryDebuggable(false)`...

@bwilkerson @pq any thoughts on this? It's possible that some diagnostics have multiple possible fixes: TypeScript just always uses the first one, but I'm not convinced that's the best decision....

@incendial can you give a concrete example? (perhaps in its own issue here or in the SDK).

> There's no logic to support choosing one from potentially multiple fixes. If we can define an algorithm for making that choice then we could implement the rest of the...

> but we might be able to do this just for this case (either at the start of identifiers, or just args, depending on feedback) by setting the `replacementRange` to...

Thanks for the report! This is a limitation of the current TextMate grammar - it's pretty simple and will detect keywords almost anywhere. You don't see the issue in the...

Oh, actually I think our fix only covers methods (things followed by parents or angle brackets): https://github.com/dart-lang/dart-syntax-highlight/commit/515bc7905ea7fe83bf18a93f90818f34d80bd952 I fixing some of these issues will require making the TM grammar much...

@bwilkerson @parlough it looks like this was done in https://dart-review.googlesource.com/c/sdk/+/384940. I'm not sure what motivated this, but I do feel like it's taken away a nice feature of seeing the...

I feel like what we showed before in the IDE was just the right amount * - there was a description of the lint (more than just the name), and...