Danny Tuppeny
Danny Tuppeny
Thanks for the extra info! > One thing I noticed when recording this is that it doesn't seem to take the win. It found the symbol, but it paused while...
I did some more testing today, and noticed something I had missed previously. The first search is a lot slower (I don't know exactly why, there's probably some compilation going...
@gspencergoog the `#` isn't part of the search, that's just how VS Code differentiates when using symbol search in the command palette (eg. if you open the general command palette...
If you mean the markdown search, that's sadly not warming anything for us - we (the Dart server) are not involved at all. When you do a workspace search, VS...
@gspencergoog any feedback on the performance of this lately? It came up elsewhere too and I'm wondering if the last set of changes made much difference.
The changes were in the SDK, so if you're on Flutter master you'd have them already 😞 Is 25-30s what you see for the first search, or subsequent searches? I'm...
Thanks for the numbers and logs! If it's always < 1s for subsequent searches that doesn't sound too bad. I'll do some profiling to understand exactly what takes time on...
@gspencergoog not that I know of (or can find). Some of the other searches (like Find References) can now be run in a way that shows results in the sidebar,...
You're right that all of the refactors like this are handled in the [Dart analysis server](https://github.com/dart-lang/sdk/tree/master/pkg/analysis_server). Dart-Code doesn't do any language parsing itself, so it doesn't have the necessary information...
> To the best of my knowledge (Danny can correct me if I'm wrong here), LSP only supports one refactoring (rename) and doesn't even provide the support we'd need to...