Danny Tuppeny

Results 1798 comments of Danny Tuppeny

Unfortunately I had to remove the code that was doing this, because it was also messing up code blocks. For example: ```dart /// [foo] /// /// var foo = "test";...

@bwilkerson interesting idea, though I don't think from the documentation on a `hover` request we have the necessary info to map it back to a specific source location (we don't...

> changes are successfully flushed to my code and the file is saved [...]. However, my app does not hot reload until I click back into the editor and press...

I'm a bit hazy on this right now, but as I remember, yaml_edit does the right thing for content that has newlines: https://github.com/dart-lang/tools/blob/24707e094cd761178eb76e725ce17f51e22fd442/pkgs/yaml_edit/lib/src/utils.dart#L265 But there's some awkwardness when the file...

There was some back and forth about whether VS Code or GitHub was correct here and I filed https://github.com/github-linguist/linguist/issues/7015 thinking it was a GitHub issue. However, @RedCMD did some more...

> I'm not sure if it should be fixed, as Markdown heavily relies on VSCode's behaviour While I agree that VS Code's behaviour seems better, I don't think diverging from...

I'm not sure that this distinction works in Dart and trying to do this could be misleading. Consider the following: ```dart void main() { printA(B()); } void printA(A a) {...

> Okay, but I think the suggest widget already distinguishes between fields and getter-setters. I didn't realise this, but you're right - the icons are different: ![image](https://github.com/Dart-Code/Dart-Code/assets/1078012/67b58bd5-4d01-44d1-b184-4846be4f468d) I'm not certain...

> If the user doesn't need to know / understand something, then it's not worthwhile trying to do it that way. While I agree it might not be so important...

> If the user accesses a getter-setter overriding a field, then the it should be coloured as a getter-setter in that specific instance. We can only base the colouring on...