Danny Tuppeny
Danny Tuppeny
I'm splitting this because there are two parts to this that might ship separately. This issue is for the "Fix All in Workspace" commands, which are invoked from the palette....
Turns out, this was fixed more recently than I remembered and hasn't made it to a stable release yet: https://github.com/dart-lang/sdk/commit/59294606cf8c5d07d98c9beac4eff43dbf609f11 I tested on Flutter stable and it's truncated, but on...
I've renamed this issue and will use it to track the inconsistency noted above (the fix may be for the grey text to also be truncated).
This is fixed (that is, we will consistently use truncated values unless you're in the REPL or using "Copy Value") by https://github.com/dart-lang/sdk/commit/2f2564c99f97dbea5c010f704e9b0583e122917f. The fix is in the SDK debug adapters...
The path comes from here: https://github.com/invertase/dart_custom_lint/blob/3aaed0c7ed283c1c4e4702d38e4200f1526c14a0/packages/custom_lint/lib/src/workspace.dart#L130-L132 The input (`sharedConstraint.path`) is `"D:\Dev\Temp Projects\custom_lint_lsp_bug"` and the output is `"d:/Dev/Temp%20Projects/custom_lint_lsp_bug"`.
Not using `posix.prettyUri()` works for me, though I don't know if it's the right thing in all cases: ``` // Use appropriate path separators across platforms return '\n path: ${jsonEncode(sharedConstraint.path)}';...
Making this as WIP for now because there was a bug in the `pkg:test` changes. I'll come back to this after https://github.com/dart-lang/test/pull/2499 is merged and released.
A new version of `pkg:test` was published (1.26.1) so I've updated this. This is now good to go again. @scheglov are you the right person to review this (you were...
@scheglov thanks! The failure was because the new `pkg:test` requires a newer Dart, so I've also now bumped the requirement from Dart 3.1 to Dart 3.2 in the pubspec (and...
Looks like the message from the first one wasn't the whole picture, it said: > Because test_reflective_loader depends on test >=1.25.6 which requires SDK version >=3.2.0 Because test_reflective_loader depends on...