Danny Tuppeny
Danny Tuppeny
Ok, I'll go with 2. It at gets things consistent and we can always change in future if we have better ideas. Thanks!
Unless the reason #56555 shows `_Smi` as the type name is because of the extension/aliased import, these seem like different issues to me. My understanding is: - this issue is...
Yep, that sounds right to me. Note that it will require Dart-Code changes, it won't show up anywhere automatically. We can also choose whether it's in the context menu or...
I'm not sure that would work.. In the current legacy protocol implementation, all occurences must have the same length, and they all must be in the same file. For LSP...
~~I spotted an issue with the fix here. The fix is simple, but we need some additional tests for those cases. I'll work on a CL for `main` and then...
The issue noted above has now been fixed in main and included in the cherry-pick CL.
@jensjoha out of interest, what is `_Smi` and what's the relationship to `int`? If I evaluate `i.runtimeType` I get back something that includes `int` but doesn't mention `Smi`: ```js {...
@jensjoha thanks, that's really useful! I've seen something like a "OneByteString"(?) class show up in some of these places too, and I guess there's some similar optimisation going on there....
`**/foo.dart` won't match `foo.dart` in the root folder (presumably because it's checking the relative path `foo.dart` and not matching a `/`), though I'm not sure that's all that important since...
Maybe related to the original issue? https://github.com/dart-lang/tools/issues/1983