Dan Klishch
Dan Klishch
Hmm, apparently Serenity relies heavily on the bugs of the old timer handling code...
This is mostly for my coroutines branch, code there becomes a bit nicer with these changes. And I want to upstream as much as possible before the main async PR....
> cost any more than a couple ms afaict Btw, haven't Andreas just recently talked about saving 5ms per request?
Fine, will do this as a part of coroutines mega PR (if I ever finish it)
I've found a much more elegant solution for only linking required functions from libc. @ADKaster, I think you would love how DynamicLoader/CMakeLists.txt looks now.
> I do wonder if we could come up with a static list of LibC files or symbols we need for the loader. I think this could have worked, if...
Static libc we "had" didn't even work, it just was there.
Seems like was/were after "if" somehow depends on the factuality of the clause (https://ell.stackexchange.com/a/127747), though I cannot decide whether "if DynamicLoader were invoked directly" is a fact or an imaginary...
> Also, do you have an example of such program being run with /usr/lib/Loader.so? Yes! `cd /usr/Tests/LibELF; /usr/lib/Loader.so /usr/Tests/LibELF/TestDlOpen` crashes on master and works with this PR.