DanRyanIrish

Results 154 comments of DanRyanIrish

Here is an example of including fixtures in parameterisations: https://github.com/sunpy/ndcube/blob/main/ndcube/tests/test_ndcube.py#L48 The trick is to add this `indirect` kwarg at the end of the parameterisation given the name of the input...

Hi @PCJY. The tests are looking good now. However, could you please rename them `test_arithmetic_add_...`, rather than `test_cube_add...`, as the test actually uses the arithmetic operator `+`, and only tests...

Hi @PCJY. I've edited your mask discussion in the PR description. I've created a table for all the scenarios for determining the result of adding the masked data. Can you...

Hi @PCJY Regarding you question in the PR description: > My understanding: > handle_mask is a function, as long as it has a value, it will be True, and does...

@PCJY: Regarding your comments on the distinct cases in the PR description: > When OIM is T, the result is always 3, i.e. the actual result of the addition of...

@PCJY Let me know when this is ready for another review. Also, be sure to pull the latest changes from the main branch into this branch.

This could also be the basis of a talk or tutorial. A few of us had discussions yesterday, including with some non-sunpy folks, and it's clear that many of us...

Posting a draft of my thoughts on a possible talk/tutorial so I can find them again. For the most recent version of these thoughts, see [this google doc](https://docs.google.com/document/d/15-7jkyt_2xiUn-BXVib_aCiFKrSFtWSjUqbV63Cmm6s/edit?usp=sharing). # Why...

This is very much a mind-dump, but it does provide first-draft structure and content. More drafting should be done, but now at a stage where it would be good to...

> Care should be taken to make sure we aren't (excessively) repeating or contradicting other parts of our docs. Is anything I've said here wrong @wtbarnes ?