Some issues i encountered.

[NullArray]

Hello, not sure if you are still maintaining this repository but i just wanted to mention a few things.

Your xpath needs to be changed to; find_elements_by_xpath("//div[@data-hveid]/div/div/a[@onmousedown]")

To reflect the current Google source code.

Also, i seem to be getting a selenium error. I realize you don't maintain the selenium library but maybe you had some thoughts.

  File "/usr/local/lib/python2.7/dist-packages/selenium/webdriver/firefox/webdriver.py", line 174, in __init__
    keep_alive=True)
  File "/usr/local/lib/python2.7/dist-packages/selenium/webdriver/remote/webdriver.py", line 157, in __init__
    self.start_session(capabilities, browser_profile)
  File "/usr/local/lib/python2.7/dist-packages/selenium/webdriver/remote/webdriver.py", line 252, in start_session
    response = self.execute(Command.NEW_SESSION, parameters)
  File "/usr/local/lib/python2.7/dist-packages/selenium/webdriver/remote/webdriver.py", line 321, in execute
    self.error_handler.check_response(response)
  File "/usr/local/lib/python2.7/dist-packages/selenium/webdriver/remote/errorhandler.py", line 242, in check_response
    raise exception_class(message, screen, stacktrace)
selenium.common.exceptions.WebDriverException: Message: newSession

The problem seems to be in the response handler. I had a quick glance at first and when i saw; message, screen, stacktrace In the error message it reminded me of an issue i resolved that had to do with python virtual display. I did not encounter this issue on BackBox Ubuntu but on Debian the virtual display issue was resolved by adding the following code.

from pyvirtualdisplay import Display

display = Display(visible=0, size=(800, 600))
display.start()

It was my initial thought that this might be the issue on my current distro as well. Running Lubuntu at the moment. Adding the above code did not seem to fix it.

In any case, if you're still around. Any ideas on how to resolve this issue?

[DanMcInerney]

No idea. I built this as just a little one off toy script when shellshock came out and dont have any interest in maintaining it although I will blindly merge any PRs.

On Tue, Feb 12, 2019, 7:01 AM NullArray <[email protected] wrote:

Hello, not sure if you are still maintaining this repository but i just wanted to mention a few things.

Your xpath needs to be changed to; find_elements_by_xpath("//div[@data-hveid]/div/div/a[@onmousedown]")

To reflect the current Google source code.

Also, i seem to be getting a selenium error. I realize you don't maintain the selenium library but maybe you had some thoughts.

File "/usr/local/lib/python2.7/dist-packages/selenium/webdriver/firefox/webdriver.py", line 174, in init keep_alive=True) File "/usr/local/lib/python2.7/dist-packages/selenium/webdriver/remote/webdriver.py", line 157, in init self.start_session(capabilities, browser_profile) File "/usr/local/lib/python2.7/dist-packages/selenium/webdriver/remote/webdriver.py", line 252, in start_session response = self.execute(Command.NEW_SESSION, parameters) File "/usr/local/lib/python2.7/dist-packages/selenium/webdriver/remote/webdriver.py", line 321, in execute self.error_handler.check_response(response) File "/usr/local/lib/python2.7/dist-packages/selenium/webdriver/remote/errorhandler.py", line 242, in check_response raise exception_class(message, screen, stacktrace) selenium.common.exceptions.WebDriverException: Message: newSession

The problem seems to be in the response handler. I had a quick glance at first and when i saw; message, screen, stacktrace In the error message it reminded me of an issue i resolved that had to do with python virtual display. I did not encounter this issue on BackBox Ubuntu but on Debian the virtual display issue was resolved by adding the following code.

from pyvirtualdisplay import Display

display = Display(visible=0, size=(800, 600)) display.start()

It was my initial thought that this might be the issue on my current distro as well. Running Lubuntu at the moment. Adding the above code did not seem to fix it.

In any case, if you're still around. Any ideas on how to resolve this issue?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/DanMcInerney/shellshock-hunter-google/issues/1, or mute the thread https://github.com/notifications/unsubscribe-auth/ABuspchR1jROMomLqeHhgpflQoSQcdkLks5vMtc3gaJpZM4a2l2N .

[NullArray]

Thank you for the quick response. And i see. The main problem with your implementation in it's current form is just the xpath as far as i can tell. I might just downgrade selenium to a previous version, since this issue is new to me. I have a couple of projects with selenium and geckodriver as well and when i tested those scripts i got the same error as in the code block i posted above. So it seems pretty clear selenium is the issue here.

I may send in a PR, schedule allowing, some optimization, running geckodriver in headless mode and fixing the xpath would be the focus of that i think. Of course, you'll know if and when i submit a pull.

Thanks again for the response :+1: