Dan Gould comments

Results 340 comments of


                                            Dan Gould

BIP 371 noncompliance: Taproot fields remain after adding `PSBT_IN_FINAL_SCRIPTWITNESS` in finalize_psbt

Thanks for tackling this @evanlinjin

Set default proxy ports to spec

Based on some examples [using 8080 in this codebase], I have a feeling it was just a mistake carried over in testing. The RFC that defines HTTP and the CONNECT...

Set default proxy ports to spec

Looks like [SOCKS conventionally listens on port 1080 by spec](https://datatracker.ietf.org/doc/html/rfc1928#section-3) actually, so I've adjusted the default behavior to match that too

Set default proxy ports to spec

force pushed to fix clippy lints

Set default proxy ports to spec

In further testing, I discovered that `Url::parse` discards the port if it is assumed to be the default port for the scheme. So, for example passing `Url::parse(&"http://example.com:80")?` to the proxy...

Set default proxy ports to spec

> So what are we saying the behavior for http://example.com:80 should be with regards to the proxy port? ## Current behavior - an `Agent` with `Proxy::new("http://example.com:80")` sends requests to `example.com:8080`...

Set default proxy ports to spec

Yes. I think this is a breaking change for anyone depending on the 8080 default. That's an odd behavior to depend on but I wouldn't say it's impossible.

Set default proxy ports to spec

Thanks for sticking with me and merging this. I think this makes #719 a bit easier so I'll have a revisit to that now

Add HTTPS proxy support

force pushed to fix clippy lints

Release outdated?

I'd love to see the latest published. Those changes would help out a ton