Isn't picking up W (West) in street names

[roymap]

eg. 245 Queen St W eg. 216 18th E street

[DamonOehlman]

@roymap I suspect this is going to be a tricky(ish) one but I'll see if we can modify the regexes to pick these up. One of the main issues with a freeform parser is that some of the edge cases are very hard to cater for.

I recall @markstos mentioning he was now using contact-parser instead of addressit. Might be worth checking out if they handle that case.

I will be attempting to fix it here though also :)

[roymap]

contact-parser is horrible and doesn't come close to addressit even when we "clean" the input text.

[markstos]

For comparison, but addressit and contact-parser have had 11 issues opened. contact-parser has address 10 of them. addressit has closed 2.

@roymap a direct comparison of where addressit parses better than contact-parser would be helpful. Just deriding contact-parser as "horrible" does little to advance the comparison.

[DamonOehlman]

@roymap Agree with @markstos - if it's possible to provide some more concrete details I think that would be constructive.

Also, would you be able to provide the full addresses that failed parsing please. I updated the tests to include a 245 Queen St W on an existing test, but it behaved as it should have. Thanks.

[asharafshahi]

Oddly, very standard US addresses seem to be failing (no state is identified below):

Address { text: '765 Medical Center Court, Suite 209, Chula Vista, CA, 91911', parts: [], unit: undefined, number: '209,', street: 'Chula Vista', state: undefined, country: undefined, postalcode: '91911', regions: [ 'Court', 'Suite CA' ] }

[markstos]

Try without the Suite 209 fragment.

On Sun, Nov 11, 2018, 7:13 PM asharafshahi [email protected] wrote:

Oddly, very standard US addresses seem to be failing (no state is identified below):

Address { text: '765 Medical Center Court, Suite 209, Chula Vista, CA, 91911 https://maps.google.com/?q=765+Medical+Center+Court,+Suite+209,+Chula+Vista,+CA,+91911&entry=gmail&source=g ', parts: [], unit: undefined, number: '209,', street: 'Chula Vista', state: undefined, country: undefined, postalcode: '91911', regions: [ 'Court', 'Suite CA' ] }

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/DamonOehlman/addressit/issues/19#issuecomment-437719030, or mute the thread https://github.com/notifications/unsubscribe-auth/AABk5SXv_Tw0XQdUs66BbcwMlC2U54S5ks5uuL0zgaJpZM4J_A6z .

--

Mark StosbergDirector of Systems and Security | RideAmigos https://rideamigos.com/ | 765-277-1916 | [email protected] [email protected]