anaconda icon indicating copy to clipboard operation
anaconda copied to clipboard

Adds linting messages on line hover to anaconda. Resolves #862

Open Kyu opened this issue 4 years ago • 8 comments

* Added on_hover listener to show a popup if a line contains a linting messages
* Added "anaconda_linter_hover_message" to Anaconda.sublime-settings. Defaults to false.

Hi, this is my pull request for #862 . I know the contributing guide says to wait for the issue to be discussed, but I'm kinda impatient and I wanted this enhancement to be out there for others who want the feature.

Since this is a GUI feature, I didn't add any tests. Tell me if this should be fixed. This is the first Sublime plugin I'm working on, and I added some comments(questions) in the code, any assistance would be appreciated.

Fixes #862

Kyu avatar May 27 '20 02:05 Kyu

😃

image

The message "undefined name 'five'" is missing, it removes messages if there are more than 3. Not sure why. Otherwise it works fine :/

Kyu avatar May 28 '20 08:05 Kyu

Resolves #862

(Adding comment here so it is recognized bygithub)

scuml avatar Jun 02 '20 16:06 scuml

Looks good to me, anyone has any reason for this to not get merged?

DamnWidget avatar Jun 02 '20 22:06 DamnWidget

I'm for merging. Looks good.

scuml avatar Jun 02 '20 22:06 scuml

There’s a truncation issue, as I said in the other comment, also there a significan typo in show_popup I didn’t change so I’ll fix that when I get home.

Kyu avatar Jun 02 '20 22:06 Kyu

There’s a truncation issue, as I said in the other comment, also there a significan typo in show_popup I didn’t change so I’ll fix that when I get home.

I could not find anything wrong in your code that would point to the reason, I would say ship-it it is better than nothing, we could probably document this limitation

DamnWidget avatar Jun 03 '20 09:06 DamnWidget

I randomly came across this. I don't use sublime much anymore, was this feature added in a separate commit? I can update the code if needed.

Kyu avatar May 27 '22 14:05 Kyu

Any plans to merge this PR soon?

AlphonseVA avatar Sep 28 '22 20:09 AlphonseVA