fasterer icon indicating copy to clipboard operation
fasterer copied to clipboard

Published 20 hours ago • verified publisher icon DamirSvrtan

Hash#update() vs Hash#[]=

Open manjunath724 opened this issue 3 years ago • 2 comments

Hash#update is an alias for Hash#merge! Ergo, the suggestions for Hash#update should be similar to Hash#merge!

Ref https://github.com/DamirSvrtan/fasterer/issues/82

Link to Fast-Ruby PR : https://github.com/JuanitoFatas/fast-ruby/pull/195

manjunath724 avatar Aug 06 '21 12:08 manjunath724

Let me know once the Fast Ruby PR merges in, and we can then continue on!

DamirSvrtan avatar Sep 08 '21 05:09 DamirSvrtan

It was merged last April :+1:

Keen for a merge please!

hlascelles avatar Oct 05 '22 10:10 hlascelles

@DamirSvrtan Fast Ruby PR was merged, can we please merge this PR too? Thank you in advance.

ManjunathPrakash avatar Jan 10 '24 08:01 ManjunathPrakash

I have merged it, and I might have done it without thinking this through enough! I have realized though how many issues this might cause, as update is such a commonly used method name in Ruby world (especially in Active Record).

Before I cut a new version of fasterer with this update, @manjunath724, @hlascelles, can you all chime in a bit with your thoughts on whether this will clash a bit too much and produce false positives?

DamirSvrtan avatar Jan 25 '24 04:01 DamirSvrtan