Adame Dahmani

Results 121 comments of Adame Dahmani

@MathieuLamiot checking the mime is still applicable if we have a filter to allow URLs that are still valid but don't have an image mime type, like `gravatar.com`. I would...

Definitely not option 2 as it will add the wrong image. Ideally, option 1. But sounds like too much efforts + risk compromising/over complicating safeguarding data for something that won't...

Positive on this one: ``` $ftmp = preg_replace( '/\s*# BEGIN AccelerateWP.*# END AccelerateWP\s*?/isU', PHP_EOL . PHP_EOL, $ftmp ); ``` It's the same rewrite rules as ours. The exact copy actually...

Tested adding it using a filter. It broke the rewrite rule line because of `)` and it doesn't look like there is a way to skip characters while still have...

> Do we want to add it initially in 3.16 or as enhncement? As enhancement to avoid any delays. The only requirement on release is for the limits to be...

🤔 isn't the condition for it to be smaller than 1920x1080? The condition should be fine for anything smaller than this resolution, regardless of what eats the screen's realestate. >...

I think there is a misunderstanding indeed 😅 @piotrbak shouldn't this be bigger than 1920x1080? > (desktop) We have a screen _**smaller than**_ RUCSS desktop size (1920x1080) Because it we...

Let's go with @MathieuLamiot's proposal and iterate as we get feedback on mismatches.

> if the Remove Unused CSS feature is not enabled and the display condition changes we won't clear the cache and we won't display a notice similar to the one...

@CrochetFeve0251 ``` Your Elementor template was updated. Clear the cache if the display conditions were changed. ```