client icon indicating copy to clipboard operation
client copied to clipboard

Infra: allow for multiple install_hooks() running at the same time

Open kbolashev opened this issue 3 months ago • 2 comments

Infra changes:

  • Added ruff and mypy into dev dependencies (will probably add them to GH Actions in a later PR)
  • Split the DagsHubFilesystem into two classes: DagsHubFilesystem that does the file access stuff, and HookRouter that runs the hook infra + routes the functions to the correct DHFilesystem.
  • Added test scenarios testing multiple hooks running at the same time

Functional changes:

  • Now multiple install_hooks() can be running at the same time and any file access function will be routed to the correct filesystem.
  • uninstall_hooks() now has fs and path arguments that remove specific filesystems. By default all filesystems will be removed
  • Add a get_mounted_filesystems function that returns a list of tuples of (<full mount path>, <fs object>)

Shouldn't be anything backwards-incompatible from a user API perspective

kbolashev avatar Mar 14 '24 12:03 kbolashev