v-hotkey
v-hotkey copied to clipboard
Use of keycode depreciated per Vue docs
Behind the scenes, this plugin uses keycodes.
While reading the vue docs, I discovered that key codes are actually being depreciated from browsers. See: https://vuejs.org/v2/guide/events.html#Key-Codes
Should this plugin be updated for the new implementation, which appears to use built in labels for each key type? E.g., left and right arrow are ArrowLeft
and ArrowRight
respectively.
Is this on the radar for the plugin creator/maintainers? Are there any thoughts about this depreciation?
@hackerESQ we will look into it. cc @vladimyr @Dafrok
I wouldn't mind taking this on in the Vue 3 branch once the PR for that is merged.
I ended up implementing this change in my fork, and updated my PR.