v-hotkey icon indicating copy to clipboard operation
v-hotkey copied to clipboard

Use of keycode depreciated per Vue docs

Open hackeresq opened this issue 4 years ago • 3 comments

Behind the scenes, this plugin uses keycodes.

While reading the vue docs, I discovered that key codes are actually being depreciated from browsers. See: https://vuejs.org/v2/guide/events.html#Key-Codes

Should this plugin be updated for the new implementation, which appears to use built in labels for each key type? E.g., left and right arrow are ArrowLeft and ArrowRight respectively.

Is this on the radar for the plugin creator/maintainers? Are there any thoughts about this depreciation?

hackeresq avatar Jan 30 '21 23:01 hackeresq

@hackerESQ we will look into it. cc @vladimyr @Dafrok

zcuric avatar Feb 01 '21 13:02 zcuric

I wouldn't mind taking this on in the Vue 3 branch once the PR for that is merged.

semiaddict avatar Feb 28 '22 11:02 semiaddict

I ended up implementing this change in my fork, and updated my PR.

semiaddict avatar Jan 17 '23 07:01 semiaddict