Daemon icon indicating copy to clipboard operation
Daemon copied to clipboard

Demo recording with dpkdir does not store package names

Open illwieckz opened this issue 2 years ago • 3 comments

We may want to at least store package basename.

When recording a demo (for example with plat23 map) with data being loaded from dpkdir, I have to do set fs_extrapaks "map-plat23 unvanquished" to be able to load the demo, otherwise required files like map bsp and game config files are not found.

On the contrary, when recording a demo from a released game, when playing demo from main menu, required packages are loaded.

I have no idea how such package names are loaded in demos.

illwieckz avatar Mar 22 '22 04:03 illwieckz

Or maybe it's because I record with devmap, I don't know, but in the end the demo isn't usable without fs_extrapaks hacks.

illwieckz avatar Mar 22 '22 04:03 illwieckz

Well there's no checksum for a dpkdir, so there's no way to know if we're loading the right thing.

I'm tempted to suggest that recording a demo from a dpkdir should be an error, but that would testing annoying. It should print a warning at least.

slipher avatar Mar 23 '22 01:03 slipher

Having a warning is a good idea (and I would already know where lives the code if there was already one!), both when storing and when reading, telling the user such demo is not reliable.

But I would prefer storing a package list without version string (with the risk the one being loaded is too old/too new) than to store nothing.

illwieckz avatar Mar 23 '22 02:03 illwieckz