Daemon icon indicating copy to clipboard operation
Daemon copied to clipboard

Cubemap probes placement/lookup is incorrect

Open VReaperV opened this issue 1 year ago • 2 comments

https://github.com/DaemonEngine/Daemon/pull/1256#discussion_r1729140504:

The cubemap search function can only find probes that are in the same epsilon X epsilon X epsilon-sized voxel. 0.01 is unreasonably small so I assume it was inverted by mistake. 100 is still too small for it to find one the majority of the time though. Overall the code really doesn't make any sense, since the probes are generated in an irregularly spaced way according to BSP nodes, but the lookup code seemingly expects them to be evenly spaced like the light grid, or at least placed with a minimal density.

This should be evaluated at some point, but the cubemap reflections themselves should be fixed first.

VReaperV avatar Aug 23 '24 16:08 VReaperV

Here's an example of how the current placement works on plat23: unvanquished_2024-09-17_124109_000 unvanquished_2024-09-17_124037_000 unvanquished_2024-09-17_124029_000 unvanquished_2024-09-17_124020_000

VReaperV avatar Sep 17 '24 10:09 VReaperV

This will be fixed once #1355 is merged.

VReaperV avatar Oct 15 '24 07:10 VReaperV