DaanSelen

Results 464 comments of DaanSelen

@grufocom can you make this for version 4? then we can merge it.

I have looked at the change and its compatible. It should still work. Can you verify @grufocom

Would your method be better? I know that in principle that it both works, but I am willing to hear your feedback.

Anyway thanks for helping! If you have more suggestions or better ways to do it, let us know! Directly through the Discord or through GitHub!

I want to request @donaldzou for possible locations to merge this into. so I can keep track of it all while keeping it within development scope.

With the resolvement of the review I would like @donaldzou to resolve the conflicts as well to have the incoming code (in working conditions) merged.

I have not specifically used awk in this manner but I think its the same as jq slightly. For example this method: https://github.com/DaanSelen/MeshCentral/blob/59ca8b08157f7f96fcb0fb837ef6943cc0d7e22e/docker/entrypoint.sh#L54

> Let me create a dev branch and we can merge into it :) Best, Donald Zou > […](#) > ________________________________ From: Adams ***@***.***> Sent: Monday, May 12, 2025 6:24:53...

Can the conflict be resolved and the code reviewed again @AdamsGH .

What's preventing this from merger? @donaldzou can you perform some testing?