xlsx-stream-reader icon indicating copy to clipboard operation
xlsx-stream-reader copied to clipboard
verified publisher icon DaSpawn

Show formats

Open lambrojos opened this issue 6 years ago • 3 comments

A customer asked for the possiblity to see date formats, and so I had to customize the library. I'm sending this pr to ask if maybe you want to integrate this feature as well

lambrojos avatar Jan 07 '19 09:01 lambrojos

Hi @lambrojos , I have same problem as you, tried to fork your repository and install master branch, also show-formats, but it fills formats with undefined or <1 empty item>, right now the library is parsing date as 1904 time format, can I somehow make this work ?

Thanks

krutijan1 avatar May 17 '19 13:05 krutijan1

Hi @krutijan1 ,

I just submitted a PR for adding support to 1904 date format. Not sure if this will solve your issue but you can take a look.

brunoargolo avatar Jun 02 '19 02:06 brunoargolo

Hi @krutijan1 sorry for the very late answer. Yes I found myself in trouble too with date formats and as I could not wait for PRs in here to be approved I found myself forced to incorporate xlsx-stream-reader in my own library https://www.npmjs.com/package/supersalmon.

I fixed this and other parsing corner cases in there. If you want to take a look code or backport the code: https://github.com/lambrojos/supersalmon/blob/master/lib/worksheet.js

lambrojos avatar Jun 10 '19 18:06 lambrojos