rust-crypto icon indicating copy to clipboard operation
rust-crypto copied to clipboard

Published 20 hours ago • verified publisher icon DaGenix

Added a Twofish implementation.

Open scottm73 opened this issue 8 years ago • 2 comments

As per issue #345, I've written a Twofish implementation which might be usable until someone provides a better one.

scottm73 avatar May 01 '16 11:05 scottm73

Hi @scottm73, here is what I have seen so far. General checklist:

  • License is OK. It is an exact copy of the one in the aes.rs file (dual MIT Apache license).
  • Credits where given for the algorithm's author and to the author of a related implementation.
  • Test vectors were implemented and travis continuous integration tests are passing (yes, I opened the travis logs and they record the tests implemented here as passing).
  • Benchmark runs were implemented.
  • Code is very organized.
  • Pull request seems to integrate cleanly with existing code, with a minimal change to an existing file.

As I said before, I have no experience in programming in rust, so I did not check algorithm correctness or implementation caveats.

mirandadam avatar May 31 '16 16:05 mirandadam

Thanks for looking over it Daniel.

On 31 May 2016 at 17:22, Daniel Araújo Miranda [email protected] wrote:

Hi @scottm73 https://github.com/scottm73, here is what I have seen so far. General checklist:

  • License is OK. It is an exact copy of the one in the aes.rs file (dual MIT Apache license).
  • Credits where given for the algorithm's author and to the author of a related implementation.
  • Test vectors were implemented and travis continuous integration tests are passing (yes, I opened the travis logs and they record the tests implemented here as passing).
  • Benchmark runs were implemented.
  • Code is very organized.
  • Pull request seems to integrate cleanly with existing code, with a minimal change to an existing file.

As I said before, I have no experience in programming in rust, so I did not check algorithm correctness or implementation caveats.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/DaGenix/rust-crypto/pull/361#issuecomment-222741859, or mute the thread https://github.com/notifications/unsubscribe/ABcPQ-CMOF2AvYnEFZpgNGXEFI3N5_tWks5qHGBegaJpZM4IUB9b .

scottm73 avatar May 31 '16 17:05 scottm73