Pipeliner
Pipeliner copied to clipboard
DXHeroes
Improve UX in light mode
Improve colors when using "light mode" on your Mac.
- Color of
TextFieldtext, labels and icons should be more contrasting (black). - Text in
TextFieldafter saving configuration should disappear. - Background color should be white
- Save button should have label.
Current state:
Hello! Happy to have found this issue via Hacktoberfest. 🎃 I'd love to contribute, and have an idea of some WCAG 2.0 accessible contrasts that would do the trick. However most of my experience with swift is in Swift 5 on iOS. I hope this won't be an issue for contributing?
@jamie-brannan Hello Jamie! Do not hesitate to at least try to fix the contrast! 👏✅
If you have any questions do not hesitate to contact us me or @Jakub-Vacek.
Hello again @prokopsimek , quick question – in reading your contribution guide I see you have commit conventions but would you like me to follow any particular branch naming conventions?
Hi, @jamie-brannan . We use the fix branch for fixes and the feature branch for features sometimes also chore or hotfix. So the branch should be named something like fix/improve-ux or feature/light-mode or something like that. Is it clearer now for you? :)
Hello 👋 I have a few more questions about getting my environment and contributing set up.
I've got macOS 11 beta installed, Xcode 12, PromiseKit and AwaitKit – my only issue is resolving signing certificates before I can build. Or is this not necessary?
About branching, I'm new to contributing but I was wondering if it's standard procedure to always fork, then create a branch from there and a PR – simply to commit to my fork directly before creating a PR?
Hello 🙂Signing of certificates is not necessary. This is project setup which works for me:
Branching: your approach is ok 👌
| ⚠️ + 🔴 | ~ |
|---|---|
 |
Okay I've learned to resolve the signature issue. Now I have more issues with warnings and target settings 🤔. |
Since I only just updated to the beta, I'm guessing I need to create a new macOS target with macOS 11? If it's not too much trouble, what's the specs of the target you're looking to build for? (this is a bit different than iOS simulators 😂 for me but just as cool)
Thank you for your patience ✌️
Hi! 🙂 Good job with signature issues 👍Targets should be set to macOS 11 everywhere.
No problem 🙂
Sadly WidgetKit is really unhappy when it's being imported in PipelineListView.swift 😢
Hi! I hope its ok to jump on this issue thread. I'm also attempting to build the project, so I went through the screenshots above, and I still have the same warnings as @jamie-brannan but with the additional of the signing certificate errors (Jamie if you could let me know how you solved it, that would be amazing :) ).
Were these warnings eventually resolved? I'd love to know how. Thanks!!
Hi @rarcilla, there's several things to resolve your build errors. First, make sure you're running Xcode Version 12.2 beta 3. This is what resolved the WidgetKit Error for me. Second, to run without the signing certificate errors you need to turn to your Pipeliner project settings and change the under the Signing & Capabilities tab, to look as such in the screen shot below (but with your developer team of course rather than the DX team or mine 😉 ) :
@Jakub-Vacek Just a little update, I've got my Xcode sorted out, build going and reading more into the code and different strategies for storing running color schemes and assets efficiently in Swift UI for the project ;) I should have much more to come before midweek, and sources to handover!
There doesn't happen to already be a graphic chart or branding created for this projet by any chance, or that I may have over looked? Otherwise, I'll stick closely to Apple-centric colors for this PR
@jamie-brannan Great job 👍 @rarcilla Thank you 😊 Apple-centric color scheme is OK. Widget scheme should imho match or be similar to the other widgets from Apple. If you encounter any difficulties (something looks weird etc.) please let me know. 🙂
I had a little trouble at first, but at last I've cracked how to implement a ColorScheme. I'm planning my commits now and should have a clean PR ready by today! 😸