JAADec icon indicating copy to clipboard operation
JAADec copied to clipboard

Cannot decode mp4/aac

Open peet-j opened this issue 8 years ago • 9 comments

I've tried a number of different input files but cannot get this to work..

SEVERE: box 

peet-j avatar Mar 28 '18 14:03 peet-j

Hi James, looks similar to my problem with MetaBox. See my comment

dieterstueken avatar Mar 28 '18 22:03 dieterstueken

@dieterstueken awesome. that fixed it for me.

peet-j avatar Mar 29 '18 09:03 peet-j

I see the solution of the problem, but how can i edit the code of the library since when i try to do it, i see that the file is only reading? Thanks in andvance

pukka1993 avatar Mar 12 '21 14:03 pukka1993

I see the solution of the problem, but how can i edit the code of the library since when i try to do it, i see that the file is only reading? Thanks in andvance

you have to fork all files into your own repository, edit the code and make a pull request to publish your solution. see: about-pull-requests. Unfortunately this repository is dead since 5 years :-(

dieterstueken avatar Apr 16 '21 14:04 dieterstueken

Originally this fork was created for use in JDA's audio system, but that library was later refactored to allow for pluggable audio handling, and we didn't have any reason to maintain this anymore.

Since JCenter is shutting down, it's probably a good time to move to a fork anyway. Happy to update the README pointing to an active fork.

hedgehog1029 avatar Apr 16 '21 14:04 hedgehog1029

If there is an active fork being maintained I'd be happy to push developers in that direction. As @hedgehog1029 stated, this was originally pulled from a dead repository on SourceForge to Github to act as a SPI for JDA, but we haven't used it in years and I don't have the expertise or time to support this project.

DV8FromTheWorld avatar Apr 16 '21 17:04 DV8FromTheWorld

Can we agree that this is fixed @dieterstueken fork?

https://github.com/dieterstueken/JAADec

stigc avatar Apr 16 '21 17:04 stigc

@dieterstueken's fork definitely appears to be the most active. Looks like the README needs to be updated and it needs to be published to a repository, but other than that, good to go.

@dieterstueken Let me know what you're thinking in regards to pivoting traffic to your fork.

DV8FromTheWorld avatar Apr 16 '21 18:04 DV8FromTheWorld

hi @dieterstueken maybe I should create a new repository with this code, and merge your fixed into it? I could do some proper testing, already have a test suite of different AAC audio files.

stigc avatar Apr 19 '21 18:04 stigc